Julian Boldt
e26b26eca6
Release / verify (push) Canceled after 0s
CI / checks (push) Canceled after 0s
CI / frontend (push) Canceled after 0s
CI / backend (push) Canceled after 0s
Release / test (push) Canceled after 0s
Release / publish (backend) (push) Canceled after 0s
Release / publish (frontend) (push) Canceled after 0s
Release / publish (proxy) (push) Canceled after 0s
Siehe CHANGELOG.md
53 lines
2.5 KiB
Python
53 lines
2.5 KiB
Python
"""Interface identifiers/labels for populating the rule-form dropdown —
|
|
sourced live from each host via `getRule`'s template response, so it always
|
|
matches that host's actual interface assignments (lan/wan/optN, VLANs,
|
|
custom names) instead of a guessed static list.
|
|
"""
|
|
from app.models.host import OpnsenseHost
|
|
from app.schemas.host import InterfaceOption
|
|
from app.services import opnsense_client
|
|
from app.services.opnsense_client import OpnsenseAPIError
|
|
|
|
|
|
def _template_options(data: dict, field: str) -> list[InterfaceOption]:
|
|
options = data.get("rule", {}).get(field, {}) if isinstance(data, dict) else {}
|
|
return [InterfaceOption(name=name, label=meta.get("value") or name) for name, meta in options.items()]
|
|
|
|
|
|
async def get_interfaces(host: OpnsenseHost) -> list[InterfaceOption]:
|
|
return _template_options(await opnsense_client.get_rule_template(host), "interface")
|
|
|
|
|
|
async def get_protocols(host: OpnsenseHost) -> list[InterfaceOption]:
|
|
"""Unlike interfaces, protocol names are IANA-standard constants baked
|
|
into OPNsense itself, not per-host config — same list on every box (bar
|
|
version drift), so callers don't need the cross-host consistency
|
|
dance get_interfaces/check_interface_consistency exist for."""
|
|
return _template_options(await opnsense_client.get_rule_template(host), "protocol")
|
|
|
|
|
|
async def check_interface_consistency(hosts: list[OpnsenseHost], interface_name: str) -> dict[str, str]:
|
|
"""For a rule pushed to more than one host: resolves what
|
|
`interface_name` actually means on each host right now, live, and
|
|
returns {host_name: label} for hosts where it resolved (silently
|
|
skipping hosts that fail to answer — they surface their own, more
|
|
specific error later in the actual deploy).
|
|
|
|
The same identifier (e.g. "opt6") can be assigned to a completely
|
|
different physical/VLAN interface on different boxes — OPNsense's
|
|
addRule/setRule accepts it either way since it's syntactically valid
|
|
on each host individually, so nothing else catches this. Callers
|
|
should only bother calling this when len(hosts) > 1 — a single target
|
|
host can never conflict with itself.
|
|
"""
|
|
labels: dict[str, str] = {}
|
|
for host in hosts:
|
|
try:
|
|
options = await get_interfaces(host)
|
|
except OpnsenseAPIError:
|
|
continue
|
|
match = next((o.label for o in options if o.name == interface_name), None)
|
|
if match is not None:
|
|
labels[host.name] = match
|
|
return labels
|